#804 hub: fix KeyError in `get_notification_recipients`
Merged 6 years ago by mikem. Opened 6 years ago by julian8628.
julian8628/koji fix-keyerror  into  master

file modified
+1 -1
@@ -7143,7 +7143,7 @@ 

      users_usertypes = [koji.USERTYPES['NORMAL'], koji.USERTYPES['GROUP']]

      clauses = [

          'status = %(users_status)i',

-         'usertype IN %(users_usertype)s',

+         'usertype IN %(users_usertypes)s',

      ]

  

      if not build and tag_id:

@@ -45,7 +45,7 @@ 

          self.assertEqual(q.columns, ('email',))

          self.assertEqual(q.tables, ['build_notifications'])

          self.assertEqual(q.clauses, [ 'status = %(users_status)i',

-                                      'usertype IN %(users_usertype)s',

+                                      'usertype IN %(users_usertypes)s',

                                       'package_id IS NULL',

                                       'tag_id IS NULL',

                                       'success_only = FALSE'])
@@ -69,7 +69,7 @@ 

          self.assertEqual(q.columns, ('email',))

          self.assertEqual(q.tables, ['build_notifications'])

          self.assertEqual(q.clauses, ['status = %(users_status)i',

-                                      'usertype IN %(users_usertype)s',

+                                      'usertype IN %(users_usertypes)s',

                                       'package_id = %(package_id)i OR package_id IS NULL',

                                       'tag_id IS NULL',

                                       'success_only = FALSE'])
@@ -113,7 +113,7 @@ 

          self.assertEqual(q.columns, ('email',))

          self.assertEqual(q.tables, ['build_notifications'])

          self.assertEqual(q.clauses, ['status = %(users_status)i',

-                                      'usertype IN %(users_usertype)s',

+                                      'usertype IN %(users_usertypes)s',

                                       'package_id = %(package_id)i OR package_id IS NULL',

                                       'tag_id = %(tag_id)i OR tag_id IS NULL',

                                       'success_only = FALSE'])

Commit 2f60081 fixes this pull-request

Pull-Request has been merged by mikem

6 years ago