PR#802: omit the last dot of cname when krb_canon_host=True - koji

koji

#802 omit the last dot of cname when krb_canon_host=True

Merged 6 years ago by mikem. Opened 6 years ago by julian8628.

julian8628/koji krb-canon-host into master

omit the last dot of cname when krb_canon_host=True

Yuming Zhu • 6 years ago

e76b3c8

koji/__init__.py

file modified

+1 -1

		`@@ -2199,7 +2199,7 @@`
		`self.logger.warning('python-dns missing -- cannot resolve hostname')`
		`else:`
		`answer = dns_resolver.query(host, 'A')`
		`- return answer.canonical_name.to_text()`
		`+ return answer.canonical_name.to_text(omit_final_dot=True)`
		`if self.opts.get('krb_rdns', True):`
		`return socket.getfqdn(host)`
		`# else`

julian8628 commented 6 years ago

fixes: #801
relates: #653

julian8628 commented 6 years ago

@mikem @eberdnik

mikem commented 6 years ago

My only concern is that we may encounter fairly old versions of this library on rhel. Are we confident that this option will exist (and work the same) on those versions? A quick glance at the upstream code seems to say yes (looks like this option was in the initial git import from 2005 and goes at least as far back as v1.3.4.

So :thumbsup: , but I think we should get qe to verify this on rhel as part of release testing.

mikem commented 6 years ago

Commit 29aeb5f fixes this pull-request