#787 builder: make temp dir to be configured
Merged 4 years ago by mikem. Opened 4 years ago by julian8628.
julian8628/koji scmdir  into  master

file modified
+3 -1
@@ -733,7 +733,7 @@ 

          # mock 1.4+ /tmp is tmpfs mounted on each run, different

          # directory is needed for persistency

          # 'within' is equivalent to broot.path_without_to_within(broot.tmpdir())

-         base = "/builddir/tmp"

+         base = self.options.chroot_tmpdir

          if within:

              return base

          else:
@@ -5579,6 +5579,7 @@ 

      parser.add_option("--topdir", help="Specify topdir")

      parser.add_option("--topurl", help="Specify topurl")

      parser.add_option("--workdir", help="Specify workdir")

+     parser.add_option("--chroot-tmpdir", help="Specify tmpdir in buildroot")

      parser.add_option("--pluginpath", help="Specify plugin search path")

      parser.add_option("--plugin", action="append", help="Load specified plugin")

      parser.add_option("--mockdir", help="Specify mockdir")
@@ -5607,6 +5608,7 @@ 

                  'topdir': '/mnt/koji',

                  'topurl': None,

                  'workdir': '/var/tmp/koji',

+                 'chroot_tmpdir': '/chroot_tmpdir',

                  'pluginpath': '/usr/lib/koji-builder-plugins',

                  'mockdir': '/var/lib/mock',

                  'mockuser': 'kojibuilder',

file modified
+3
@@ -14,6 +14,9 @@ 

  ; The directory root for temporary storage

  ; workdir=/tmp/koji

  

+ ; The temporary directory in buildroot

+ ; chroot_tmpdir = /chroot_tmpdir

+ 

  ; The directory root for mock

  ; mockdir=/var/lib/mock

  

I'd rename it to 'mock_tmpdir' or 'chroot_tmpdir'

1 new commit added

  • rename parameter/default value - tmpdir to chroot_tmpdir
4 years ago

This looks like it should fix the issue, right? Not merely relate to it. Or am I missing something?

Commit 8f5edb9 fixes this pull-request

Pull-Request has been merged by mikem

4 years ago