PR#771: Set mock old-chroot for runroot if not new-chroot - koji

koji

#771 Set mock old-chroot for runroot if not new-chroot

Closed 6 years ago by mikem. Opened 6 years ago by puiterwijk.

puiterwijk/koji runrootoldchroot into master

Set mock old-chroot for runroot if not new-chroot

Patrick Uiterwijk • 6 years ago

efe2f87

plugins/builder/runroot.py

file modified

		`@@ -185,6 +185,8 @@`
		`mock_cmd = ['chroot']`
		`if new_chroot:`
		`mock_cmd.append('--new-chroot')`
		`+ else:`
		`+ mock_cmd.append('--old-chroot')`
		`if skip_setarch:`
		`#we can't really skip it, but we can set it to the current one instead of of the chroot one`
		`myarch = platform.uname()[5]`

puiterwijk commented 6 years ago

Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com

ngompa commented 6 years ago

Is this is a flag we want to have across the board, or is this only needed for runroot...?

puiterwijk commented 6 years ago

The kojid already has this. Runroot was missing it so far.

ngompa commented 6 years ago

The code change looks fine, as does the test output. The only failure is gssapi on EL7, which is completely unrelated to this code.

:thumbsup:

tkopecek commented 6 years ago

:thumbsup:

mikem commented 6 years ago

This does not match the behavior in kojid, and will break on older versions of mock that have neither of these options. In kojid, these options are only passed if the tag has an explicit setting of True or False. Otherwise, neither is passed.

Actually, runroot calls BuildRoot.mock(), which contains this logic. Seems like we could end up with duplicate or conflicting args.

I think this change need to be a little smarter about overrides. It should probably consider the broot.config['extra']['mock.new_chroot'] value (if there is one), and the default behavior should continue be no override.

julian8628 commented 6 years ago

I'm also working on changing the default --*-chroot behavior of mock in kojid.

As @mikem said, the problem here is older versions of mock don't have such options, so we need to check version number when creating BuildRoot.

Since we use mock cmd rather than mock python module in koji, It's a little bit tricky here to check version of mock. I'll file another PR for review.

tkopecek commented 6 years ago

What about PR #823 ?

mikem commented 6 years ago

Opting for the solution in #823