#743 Fix key access mechanism in _build_image
Merged 6 years ago by mikem. Opened 6 years ago by franzh.
franzh/koji issue742  into  master

No commits found

Fix issue: https://pagure.io/koji/issue/742
1. Fix key access mechanism
2. Add spin-* commands' unit test

a couple unused vars:

tests/test_cli/test_spin_commands.py:130:9: F841 local variable 'args' is assigned to but never used

Looks like you meant to pass this to the command but passed self.arguments instead.
The two argument lists are quite different.

tests/test_cli/test_spin_commands.py:345:69: F841 local variable 'stdout' is assigned to but never used

Perhaps we just don't need the as stdout on the with statement, or perhaps you meant to use it for checks?

minor whitespace issues:

  • please leave two lines between classes
  • please avoid trailing whitespace (I highly recommend configuring your editor to show it)

Do you have time to update this?

1 new commit added

  • fix typo, tailing white space, unused parameter
6 years ago

@mikem

commit 792b066 fixes typo, tailing white space, unused parameter issues.

Commit 3c8d5ee fixes this pull-request

Pull-Request has been merged by mikem

6 years ago