#673 functions for parsing task parameters
Merged 6 years ago by mikem. Opened 6 years ago by mikem.
mikem/koji task-params  into  master

No commits found

Task parameters are stored in a form that is convenient for unpacking and passing to the function handler, but they can be tricky to interpret correctly because

  1. the handler's function signature is not very accessible to other code
  2. the parameters can be specified in different ways (named args vs positional args)

These functions do the hard work of correctly applying the parameters to the correct function signature and returning a dictionary that can be easily interpreted.

At the moment, these functions are unused by Koji itself. In the future, I would like to shift to storing task parameters as dictionaries end-to-end (which is why the code uses the term "legacy signatures")

@tkopecek please have a look when you get a chance

How do we treat the "LEGACY" tasks in builder plugin?

It will take time to transition. When we get there, plugins will be expected to accept the new way.

For now, we include the signatures of our own plugins, but for external plugins, there is not much we can do.

:thumbsup: no problem on my side

Commit debffba fixes this pull-request

Pull-Request has been merged by mikem@redhat.com

6 years ago
Metadata