koji

Clone

#524 Add support for debugsource
Merged 4 years ago by mikem. Opened 4 years ago by ignatenkobrain.
ignatenkobrain/koji debugsource  into  master

file modified
+2 -3 
@@ -1052,9 +1052,8 @@ 
 

  

  def is_debuginfo(name):
 

      """Determines if an rpm is a debuginfo rpm, based on name"""
 

-     if name.endswith('-debuginfo') or name.find('-debuginfo-') != -1:
 

-         return True
 

-     return False
 

+     return (name.endswith('-debuginfo') or name.endswith('-debugsource') or
 

+             '-debuginfo-' in name)
 

  

  def canonArch(arch):
 

      """Given an arch, return the "canonical" arch"""

I suppose this is enough.

:thumbsup:

I would even remove that 'if' and just use 'return name.endswith...'

@tkopecek alright. fixed.

1 new commit added

  • make is_debuginfo() one-line
4 years ago

:thumbsup:

:thumbsup:

:thumbsup:

Syntax error in current version. Please check make test next time.

Also, would prefer to avoid backslash continuations unless it is the least worst option, as pep8 recommends. E.g.

    return (name.endswith('-debuginfo') or name.endswith('-debugsource') or
            '-debuginfo-' in name)

3 new commits added

  • make is_debuginfo() one-line
  • use if 'x' in s instead of str.find()
  • handle debugsource same way as debuginfo packages
4 years ago

Commit 658953a fixes this pull-request

Pull-Request has been merged by mikem@redhat.com
4 years ago
Changes Summary 1
+2 -3
file changed
koji/__init__.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.