koji

Clone

#518 Error out if krbV is unavailable and gssapi did not work
Merged 6 years ago by mikem. Opened 6 years ago by puiterwijk.
puiterwijk/koji no-silent-gssapi-only  into  master

file modified
+5 -1 
@@ -2102,7 +2102,10 @@ 
 

                  if self.gssapi_login(proxyuser=proxyuser):
 

                      return True
 

              except:
 

-                 pass
 

+                 if krbV:
 

+                     pass
 

+                 else:
 

+                     raise
 

  

          if not krbV:
 

              raise PythonImportError(
 
@@ -2196,6 +2199,7 @@ 
 

          self.new_session()
 

  

          # 60 second timeout during login
 

+         sinfo = None
 

          old_opts = self.opts
 

          self.opts = old_opts.copy()
 

          self.opts['timeout'] = 60

In python3, krbV is unavailable, which means that we should not stay
silent if gssapi login failed.

Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com

rebased
6 years ago

:thumbsup:

Commit ffdb5d6 fixes this pull-request

Pull-Request has been merged by mikem@redhat.com
6 years ago

oof, didn't notice the failing unit test....

fixed in #546
Changes Summary 1
+5 -1
file changed
koji/__init__.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.