#484 fix NoneType TypeError in deleteTag
Merged 6 years ago by mikem. Opened 6 years ago by julian8628.
julian8628/koji delete-tag  into  master

file modified
+1 -1
@@ -3137,7 +3137,7 @@ 

          update.make_revoke()

          update.execute()

  

-     tag = get_tag(tagInfo)

+     tag = get_tag(tagInfo, strict=True)

      tagID = tag['id']

  

      _tagDelete('tag_config', tagID)

fix issue#483
when calling deleteing an invalid tag, a TypeError will be thrown

Fault: <Fault 1: "<type 'exceptions.TypeError'>: 'NoneType' object has no attribute '__getitem__'">

change it to a reasonable one:

GenericError: Invalid tagInfo: xxxx

Commit 26f5f02 fixes this pull-request

Pull-Request has been merged by mikem@redhat.com

6 years ago