#4139 Remove _singleRow and _multiRow import to kojihub
Merged by tkopecek. Opened by jcupova.
jcupova/koji issue-3590  into  master

Download 4139.patch

Fixes: https://pagure.io/koji/issue/3590

flake8: commands[0]> flake8
./kojihub/kojihub.py:8906:20: F821 undefined name '_multiRow'

It appears that build_references() still uses this function

Do we know why this query wasn't changed in #3589 ?

rebased onto d982b5ac4fd464d42341a48683bd333df05fb53c

updated

It is maybe a good candidate for QueryView

rebased onto 082380290832f44e618d33d17c16ab54f98a08f6

1 new commit added

  • Remove _singleRow and _multiRow import to kojihub

rebased onto 007cfa03454aa822541e9a9962c65ef05e111957

Metadata Update from @jcupova:
- Pull-request tagged with: testing-ready

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Can you please indent this line - failing flake8.

@tkopecek fixed

rebased onto b7d193c4187b312251a6327ffd811fe5b0a45734

Commit 559dae70 fixes this pull-request

Pull-Request has been merged by tkopecek

In the future, please only use %s for value substitutions in queries.

While we do have a workaround in place that will convert these, it is better to have the correct value in the first place.

Metadata