koji

Clone

#393 remove minor version from User-Agent header
Merged 6 years ago by mikem. Opened 6 years ago by tkopecek.
tkopecek/koji issue392  into  master

file modified
+2 -2 
@@ -2297,7 +2297,7 @@ 
 

          request = dumps(args, name, allow_none=1)
 

          headers = [
 

              # connection class handles Host
 

-             ('User-Agent', 'koji/1.7'),  #XXX
 

+             ('User-Agent', 'koji/1'),
 

              ('Content-Type', 'text/xml'),
 

              ('Content-Length', str(len(request))),
 

          ]
 
@@ -2562,7 +2562,7 @@ 
 

          self.callnum += 1
 

          handler = "%s?%s" % (self.baseurl, urllib.urlencode(args))
 

          headers = [
 

-             ('User-Agent', 'koji/1.7'),  #XXX
 

+             ('User-Agent', 'koji/1'),
 

              ("Content-Type", "application/octet-stream"),
 

              ("Content-length", str(size)),
 

          ]

Related: https://pagure.io/koji/issue/392

It's unnecessary detail here, let's leave it as major version value only
for now.

Other option is to remove it completely to 'koji' without version information at all.
Edited 6 years ago by tkopecek

+1

Commit 0b4753d fixes this pull-request

Pull-Request has been merged by mikem@redhat.com
6 years ago
Metadata
None
No Tags
Flags
jenkins #173
success (100%)
Build successful
6 years ago
Changes Summary 1
+2 -2
file changed
koji/__init__.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.