moving getAllPerms code into a get_all_perms function is fine, but unnecessary here.

if perm not in all_perm_ids is not the best way to do this check. The normal way would be:

perm_id = get_perm_id(perm, strict=True)

This will conveniently allow the call to handle permissions by name as well

@mikem fixed

if perm:
    perm = get_perm_id(perm, strict=True)

I would use if perm is None, otherwise you will still hit #3802 when 0 is passed in

@mikem updated to if perm is not None. I guess you meant it this, because if perm is None cannot work when perm is None as default and we need to catch non existing perm ID's, not add check when perm is None as default.

updated to if perm is not None

ah yes, that is what I meant, thanks!

:thumbsup:

Commit 52e19b25 fixes this pull-request