#3649 Remove DisableGSSAPIProxyDNFallback option on Hub
Merged a year ago by tkopecek. Opened a year ago by jcupova.
jcupova/koji issue-3648  into  master

file modified
-8
@@ -369,14 +369,6 @@ 

                  proxy_opt = 'ProxyDNs'

              proxy_dns = [dn.strip() for dn in context.opts.get(proxy_opt, '').split(delimiter)]

  

-             # backwards compatible for GSSAPI.

-             # in old way, proxy user whitelist is ProxyDNs.

-             # TODO: this should be removed in future release

-             if authtype == koji.AUTHTYPES['GSSAPI'] and not context.opts.get(

-                     'DisableGSSAPIProxyDNFallback', False):

-                 proxy_dns += [dn.strip() for dn in

-                               context.opts.get('ProxyDNs', '').split('|')]

- 

              if client_dn in proxy_dns:

                  # the user authorized to login other users

                  username = proxyuser

file modified
-2
@@ -33,8 +33,6 @@ 

  ## Allowed Kerberos Realms separated by ','.

  ## Default value "*" indicates any Realm is allowed

  # AllowedKrbRealms = *

- ## TODO: this option should be removed in future release

- # DisableGSSAPIProxyDNFallback = False

  ## TODO: this option should be turned True in 1.34

  # DisableURLSessions = False

  

file modified
-6
@@ -445,8 +445,6 @@ 

          ['ProxyPrincipals', 'string', ''],

          ['HostPrincipalFormat', 'string', None],

          ['AllowedKrbRealms', 'string', '*'],

-         # TODO: this option should be removed in future release

-         ['DisableGSSAPIProxyDNFallback', 'boolean', False],

          # TODO:  this option should be turned True in 1.34

          ['DisableURLSessions', 'boolean', False],

  
@@ -722,10 +720,6 @@ 

      try:

          setup_logging1()

          opts = load_config(environ)

-         if opts['DisableGSSAPIProxyDNFallback']:

-             logger.warning(

-                 'Hub option DisableGSSAPIProxyDNFallback is deprecated and '

-                 'will be removed in 1.29')

          setup_logging2(opts)

          koji.util.setup_rlimits(opts)

          plugins = load_plugins(opts)

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

a year ago

Metadata Update from @relias-redhat:
- Pull-request tagged with: testing-done

a year ago

Commit f7d9a96 fixes this pull-request

Pull-Request has been merged by tkopecek

a year ago