koji

Clone

#3604 Support deleted build tag in taskinfo.
Closed 2 years ago by tkopecek. Opened 2 years ago by jkaluza.
jkaluza/koji tagname  into  master

file modified
+6 -1 
@@ -4494,7 +4494,12 @@ 
 

          lines.append("SCM URL: %s" % params[0])
 

      elif method == 'buildArch':
 

          lines.append("SRPM: %s/work/%s" % (topdir, params[0]))
 

-         lines.append("Build Tag: %s" % session.getTag(params[1])['name'])
 

+         taginfo = session.getTag(params[1])
 

+         if taginfo:
 

+             tagname = taginfo['name']
 

+         else:
 

+             tagname = str(params[1]) + " (deleted)"
 

+         lines.append("Build Tag: %s" % tagname)
 

          lines.append("Build Arch: %s" % params[2])
 

          lines.append("SRPM Kept: %r" % params[3])
 

          if len(params) > 4:

This commit handles a situation when build tag is removed for
a task for which the taskinfo is called.

Signed-off-by: Jan Kaluza jkaluza@redhat.com

Reproducer: koji -p brew -d taskinfo -v -r 48704200 -v

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready
2 years ago

issue: #3612

Could be solved by using event="auto" but this way it is backward-compatible and ok for usecase.

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done
2 years ago

Pull-Request has been closed by tkopecek
2 years ago
Metadata
None

testing-ready testing-done

Changes Summary 1
+6 -1
file changed
cli/koji_cli/commands.py
Powered by Pagure 5.14.1
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.