#3592 Use inspect.getfullargspec instead of getargspec on hub and web
Merged a year ago by tkopecek. Opened a year ago by jcupova.
jcupova/koji issue-3591  into  master

file modified
+2 -2
@@ -117,10 +117,10 @@ 

          ret = self.argspec_cache.get(func)

          if ret:

              return ret

-         ret = tuple(inspect.getargspec(func))

+         ret = tuple(inspect.getfullargspec(func))

          if inspect.ismethod(func) and func.__self__:

              # bound method, remove first arg

-             args, varargs, varkw, defaults = ret

+             args, varargs, varkw, defaults, kwonlyargs, kwonlydefaults, ann = ret

              if args:

                  aname = args[0]  # generally "self"

                  del args[0]

@@ -216,7 +216,7 @@ 

                  if not inspect.isfunction(val):

                      continue

                  # err on the side of paranoia

-                 args = inspect.getargspec(val)

+                 args = inspect.getfullargspec(val)

                  if not args[0] or args[0][0] != 'environ':

                      continue

              except Exception:
@@ -257,7 +257,8 @@ 

              if isinstance(val, list) and len(val) == 1:

                  data[arg] = val[0]

          environ['koji.form'] = fs

-         args, varargs, varkw, defaults = inspect.getargspec(func)

+         args, varargs, varkw, defaults, kwonlyargs, kwonlydefaults, ann = \

+             inspect.getfullargspec(func)

          if not varkw:

              # remove any unexpected args

              data = dslice(data, args, strict=False)

Fxes: https://pagure.io/koji/issue/3591

That does seem to fix things. Thanks. I am hoping this can be in the next 1.31.1 release.

Commit 79c4192 fixes this pull-request

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-done, testing-ready

a year ago

Pull-Request has been merged by tkopecek

a year ago