#3576 kojivmd: improve topurl example and error handling
Merged a year ago by tkopecek. Opened a year ago by ktdreyer.
ktdreyer/koji win-topurl  into  master

file modified
+1
@@ -715,6 +715,7 @@ 

              koji.ensuredir(os.path.dirname(localpath))

              # closing needs to be used for requests < 2.18.0

              with closing(requests.get(remote_url, stream=True)) as response:

+                 response.raise_for_status()

                  with open(localpath, 'wb') as f:

                      for chunk in response.iter_content(chunk_size=65536):

                          f.write(chunk)

file modified
+1 -1
@@ -15,7 +15,7 @@ 

  ; workdir=/tmp/koji

  

  ; The url where the Koji root directory (/mnt/koji) can be accessed

- topurl=http://koji.example.com/kojiroot

+ topurl=http://koji.example.com/kojifiles

  

  ; The URL for the xmlrpc server

  server=http://hub.example.com/kojihub

The sample kojivmd.conf uses a topurl of kojiroot, not kojifiles. Update the example configuration to match what users will normally expect.

Also, add HTTP error checking to kojivmd so it's easier to understand when topurl is mis-configured.

Metadata Update from @tkopecek:
- Pull-request tagged with: no_qe

a year ago

Commit e9b5ec2 fixes this pull-request

Pull-Request has been merged by tkopecek

a year ago