#3505 kojivmd: pass "-F qcow2" to qemu-img create
Merged 2 years ago by tkopecek. Opened 2 years ago by ktdreyer.
ktdreyer/koji kojivmd-qemu-img-create  into  master

file modified
+2 -1
@@ -455,7 +455,8 @@ 

      def mkqcow2(self, clone_name, source_disk, disk_num):

          new_name = clone_name + '-disk-' + str(disk_num) + self.QCOW2_EXT

          new_path = os.path.join(self.options.imagedir, new_name)

-         cmd = ['/usr/bin/qemu-img', 'create', '-f', 'qcow2', '-o', 'backing_file=%s' % source_disk,

+         cmd = ['/usr/bin/qemu-img', 'create', '-f', 'qcow2', '-o',

+                'backing_file=%s' % source_disk, '-F', 'qcow2',

                 new_path]

          proc = subprocess.Popen(cmd,

                                  stdout=subprocess.PIPE, stderr=subprocess.STDOUT, close_fds=True)

In RHEL 9 (qemu-img-6.2.0-11.el9_0.3), the qemu-img create command requires the -F flag that specifies the second image's format.

Checking back to RHEL 7, qemu-img-1.5.3-175.el7_9.6 recognizes this -F flag also, so it should be safe to use on all supported platforms.

Metadata Update from @tkopecek:
- Pull-request tagged with: no_qe

2 years ago

Commit 9f71d3c fixes this pull-request

Pull-Request has been merged by tkopecek

2 years ago
Metadata