koji

Clone

#3445 Don't crash in _checkImageState if there's no image.os_plugin
Merged 2 years ago by tkopecek. Opened 2 years ago by adamwill.
adamwill/koji imgfactory-noplugin-traceback  into  master

file modified
+2 -1 
@@ -4164,7 +4164,8 @@ 
 

              if scrnshot:
 

                  ext = scrnshot[-3:]
 

                  self.uploadFile(scrnshot, remoteName='screenshot.%s' % ext)
 

-             image.os_plugin.abort()  # forcibly tear down the VM
 

+             if image.os_plugin:
 

+                 image.os_plugin.abort()  # forcibly tear down the VM
 

              # TODO abort when a task is CANCELLED
 

              if not self.session.checkUpload('', os.path.basename(self.ozlog)):
 

                  self.tlog.removeHandler(self.fhandler)

We've seen some tasks lately where Koji crashed trying to do
image.os_plugin.abort(), e.g.:

https://koji.fedoraproject.org/koji/taskinfo?taskID=89750587
https://koji.fedoraproject.org/koji/taskinfo?taskID=89671944

The fix seems fairly simple: only try and abort if os_plugin
actually exists.

Signed-off-by: Adam Williamson awilliam@redhat.com

Issue #3447

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready
2 years ago

As best as I can tell the CI failure is due to CI being broken, not the pull request.

pretty please pagure-ci rebuild
2 years ago

pretty please pagure-ci rebuild
2 years ago

pretty please pagure-ci rebuild
2 years ago

Metadata Update from @tkopecek:
- Pull-request untagged with: testing-ready
- Pull-request tagged with: no_qe
2 years ago

Commit e8a94ea fixes this pull-request

Pull-Request has been merged by tkopecek
2 years ago
Metadata
None

no_qe

Changes Summary 1
+2 -1
file changed
builder/kojid
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.