PR#3428: Fix arches check in kiwi plugin - koji

koji

#3428 Fix arches check in kiwi plugin

Merged 2 years ago by tkopecek. Opened 2 years ago by jcupova.

jcupova/koji issue-3427 into master

Jana Cupova • 2 years ago

8c9d2e7

plugins/hub/kiwi.py

file modified

+7 -2

		`@@ -24,8 +24,13 @@`
		`if repos:`
		`kojihub.convert_value(repos, cast=list, check_only=True)`
		`kojihub.get_build_target(target, strict=True)`
		`- arches = koji.parse_arches(arches, strict=True, allow_none=False)`
		`- optional_arches = koji.parse_arches(optional_arches, strict=True, allow_none=True)`
		`+ if isinstance(arches, list):`
		`+ arches = " ".join(arches)`
		`+ arches = koji.parse_arches(arches, to_list=True, strict=True, allow_none=False)`
		`+ if isinstance(optional_arches, list):`
		`+ optional_arches = " ".join(optional_arches)`
		`+ optional_arches = koji.parse_arches(`
		`+ optional_arches, to_list=True, strict=True, allow_none=True)`
		`taskOpts = {`
		`'channel': 'image',`
		`}`

jcupova commented 2 years ago

Fixes: https://pagure.io/koji/issue/3427

julian8628 commented 2 years ago

I think it looks better to have koji.parse_arches accept list arches, so that hub's kiwiBuild api is able to handle comma-, space-separated string and list as arches and optional_arches