#3404 don't propagate SIGHUP ignore to child processes
Merged 6 days ago by tkopecek. Opened 2 months ago by tkopecek.
tkopecek/koji issue672  into  master

file modified
+3 -3
@@ -37,7 +37,6 @@ 

  import pwd

  import random

  import re

- import signal

  import socket

  import struct

  import sys
@@ -584,8 +583,9 @@ 

      if pid:

          os._exit(0)

      os.setsid()

-     signal.signal(signal.SIGHUP, signal.SIG_IGN)

-     # fork again

+     # fork again, no need to ignore SIGHUP

+     # https://pagure.io/koji/issue/672

+     # https://code.activestate.com/recipes/278731-creating-a-daemon-the-/

      pid = os.fork()

      if pid:

          os._exit(0)

rebased onto 279d912

a month ago

pretty please pagure-ci rebuild

13 days ago

This is the first option from #672, "stop ignoring sighup"

LGTM

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

12 days ago

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

6 days ago

rebased onto 2006ab1

6 days ago

Commit 7a1778a fixes this pull-request

Pull-Request has been merged by tkopecek

6 days ago
Metadata