#3391 Use compression_type in listArchiveFiles
Merged by tkopecek. Opened by jcupova.
jcupova/koji issue-855  into  master

Download 3391.patch

Fixes: https://pagure.io/koji/issue/855

to accomplish this functionality, it's better to let addArchiveType support adding archive_type with compression_type.
And the values of compression_type are limited to 'tar', 'zip' by implementation so far, so we could check the values in addArchiveType too. On the other hand, we can just ignore invalid/not-implemented values. What do you think?

rebased onto dcac7e25e3ac6b20b49a45b1cd537bdc917191b6

sure, it make sense to check compression_type in addArchiveType. All fixed in PR now.

I think None is better than '' here, so the default value of compression_type can be None.

And this part could be

    convert_value(compression_type, cast=str, none_allowed=True, check_only=True)
    if compression_type not in ['zip', 'tar', None]:
        ...

rebased onto 512c9fb6866087d54926503ff7161c1474de015e

ok, when we want to use None, yes, we can do it like you wrote...so, updated with None value.

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

rebased onto eddfbf695b310081ff4be35b7ff6c516c6332f67

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 576d04ed fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata