#3282 Add extra of builds to listTagged call result
Merged 2 years ago by tkopecek. Opened 2 years ago by jcupova.
jcupova/koji issue-3110  into  master

No commits found

  1. The extra data is expected to be a json, so you can convert it to a sensible data structure, see get_build() and _fix_extra_field()
  2. As the result of listTagged usually contains a number of items, and extra data are too big or not necessary to display, we could have an option to turn it on/off.

rebased onto 4e6045d45b38fb9602d2be9540029744974c9c75

2 years ago

and more here:
1. The rpm and archive entities both have an extra field too, so maybe we could bring the option to readTaggedRPMS and listTaggedArchives (readTaggedArchives) as well?
2. the docstrings could be updated to honor the new option

rebased onto 7073b87c8598d90fb2743fab24b7fe5339ac2414

2 years ago

@julian8628 fixed and I fixed also issue #3283 in this PR.

for backward compatibility, the default extra of listTaggedArchives and listTaggedRPMS should be True

Otherwise, :thumbsup:

rebased onto 8a227443b311853455afb0fc36cd0c2c7255f50a

2 years ago

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

2 years ago

Metadata Update from @tkopecek:
- Pull-request untagged with: testing-ready

2 years ago

Ouch, now've seen #3283 - we can't rename deliberately that option. Let's stay with 'type' for now. Maybe we could create separate PR with new alias option (while still having the old one) and deprecation warning but can't remove it directly.

You can call __builtins__.type(arch) instead to refer to overridden method. (or theoretically better import builtins; builtins.type(arch) - but we don't expect to run anything else than cPython.

rebased onto 0b1e820b6c5062adf972326d715b63a581937970

2 years ago

rebased onto d3c165aa3fd04d86da5208f8c2c46c4a9969111a

2 years ago

@tkopecek ok, I'll do this change for type in the separate PR. This PR is related to extra option only.

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

2 years ago

rebased onto e9eb8961f5d9f1ca19aed70dc05b9febf36d83eb

2 years ago

Metadata Update from @jcupova:
- Pull-request untagged with: testing-ready

2 years ago

Metadata Update from @jcupova:
- Pull-request tagged with: testing-ready

2 years ago

rebased onto fd2615d

2 years ago

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

2 years ago

Commit 87aa8eb fixes this pull-request

Pull-Request has been merged by tkopecek

2 years ago
Metadata