#3277 Weak dep on `httpd.service` for kojid/ra
Merged 2 years ago by tkopecek. Opened 2 years ago by jcpunk.
jcpunk/koji wants-httpd  into  master

file modified
+2 -1
@@ -2,7 +2,8 @@ 

  Description=Koji build server

  Documentation=https://docs.pagure.org/koji/server_howto/

  

- After=network.target

+ # If the koji-hub is on this host, httpd.service is needed first

+ After=network.target httpd.service

  

  [Service]

  ExecStart=/usr/sbin/kojid \

file modified
+2 -1
@@ -2,7 +2,8 @@ 

  Description=Koji repo administration

  Documentation=https://docs.pagure.org/koji/server_howto/

  

- After=network.target

+ # If the koji-hub is on this host, httpd.service is needed first

+ After=network.target httpd.service

  

  [Service]

  ExecStart=/usr/sbin/kojira \

If you're running kojid or kojira on the same host as as the koji-hub, it is helpful to have these startup after the httpd.service has loaded.

These are weak deps, so hosts without httpd.service wont see any difference in their startup.

This way, if you have httpd installed on your builder (but it is a separate machine, so httpd.service is normally not running there), it will force start of httpd (which is not what you want).

You probably want to use After= instead, but I have not tested if it will behave as you want.

good call, I've switched to After= and re-pushed.

I would just add a claryfiyng comment there, so people are not puzzled what it does there or if httpd is somehow utilized by these services.

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

2 years ago

rebased onto fd272ec

2 years ago

Added comment, how does that look?

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

2 years ago

Commit 6b0dfae fixes this pull-request

Pull-Request has been merged by tkopecek

2 years ago