PR#3186: Don't fail on missing buildroot tag - koji

koji

#3186 Don't fail on missing buildroot tag

Merged 2 years ago by tkopecek. Opened 2 years ago by tkopecek.

tkopecek/koji issue3185 into master

Don't fail on missing buildroot tag

Tomas Kopecek • 2 years ago

b48bc7c

hub/kojihub.py

file modified

+4 -2

		`@@ -9700,8 +9700,10 @@`
		`tags[None] = None`
		`else:`
		`tinfo = get_buildroot(br_id, strict=True)`
		`- tags[tinfo['tag_name']] = get_tag(tinfo['tag_name'], strict=True,`
		`- event=tinfo['repo_create_event_id'])`
		`+ # CG don't need to have buildroots based on tags`
		`+ if tinfo['tag_name']:`
		`+ tags[tinfo['tag_name']] = get_tag(tinfo['tag_name'], strict=True,`
		`+ event=tinfo['repo_create_event_id'])`

		`if taginfo:`
		`tags = tags.values()`

tkopecek commented 2 years ago

Fixes: https://pagure.io/koji/issue/3185

pretty please pagure-ci rebuild

2 years ago

mikem commented 2 years ago

Looks good. In the case when tinfo['tag_name'] is missing, we're looking at a cg buildroot (no standard_buildroot entry). For those cases, the notion of determining build tag from buildroot info just doesn't work and likely there simply is no build tag.

Longer term, we probably want to think about how CGs should indicate a build tag when applicable, but for now this is certainly a reasonable fix.

mikem commented 2 years ago

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

2 years ago