It is not quite universal and not addressing the issue I've mentioned (still have access to exact value).

1) Extend the function for more relevant units (if value < 10^3 return value, elif value < 10^6 .. kb, < 10^9 MB, else GB)
2) Add option natural=True -> In such case, conversion will be done, otherwise original behaviour (just add commas) is used
3) Where it is used in web ui, display natural=True by default and for mouseover (e.g. via title depending on underlying tag) display it with natural=False.

I think this method should be renamed, rather than adding a new kwarg

@tkopecek @ktdreyer fixed. Now we have two methods (formatThousands and formatNatural). Default for webUI is formatNatural, added hover text on size, which shows formatThousands size. This function is used not only for rpminfo page, but also for fileinfo, imageinfo and archiveinfo.

This works great in my testing.

:thumbsup:

By the way, here's how I tested this with the fakeweb utility in the tree.

1. Create a devtools/fakeweb.conf file:

[web]
SiteName = koji
KojiHubURL = https://koji.fedoraproject.org/kojihub
KojiFilesURL = https://kojipkgs.fedoraproject.org/
Secret = toomanysecrets
PythonDebug = on
LogLevel = DEBUG
# prevent web code from tweaking the path
LibPath = /nosuchpath

1. Run ./devtools/fakeweb

2. Open http://localhost:8000/rpminfo?rpmID=28392141 in the browser

WIthout this change, the web UI shows "Size 6,276,266". WIth this change, it shows "Size 5.99 MB"

Commit f2f4a3dc fixes this pull-request