#3104 Make setup.py executable
Merged 5 months ago by tkopecek. Opened 7 months ago by oturpe.
oturpe/koji exec-setup-py  into  master

file modified
@@ -1,3 +1,4 @@ 

+ #!/usr/bin/env python

  from __future__ import absolute_import


  from setuptools import setup

In order use setup.py locally, it needs to be executable.
Also, it is easier to call with a hashbang.

Don't most projects run python setup.py instead of ./setup.py?

Don't most projects run python setup.py instead of ./setup.py?

I have not contributed to enough python projects so say what most projects do,
but this is the only one that I have met whose setup.py is not runnable with ./setup.py.
I have only started with Python because it is in heavy use in Fedora,
the others where I have done something are rpkg, fedpkg, FedoraReview and anitya.

I think that main reason fro "general" python projects is portability to e.g. windows where hashbang doesn't help. setuptools examples shows it with python setup.py. On the other hand there is no harm in making it executable as we're hardly "general" project.

Metadata Update from @tkopecek:
- Pull-request tagged with: no_qe

5 months ago

Commit f85f895 fixes this pull-request

Pull-Request has been merged by tkopecek

5 months ago