PR#2937: Update webUI number of tasks - koji

koji

#2937 Update webUI number of tasks

Merged 10 months ago by tkopecek. Opened 10 months ago by jcupova.

jcupova/koji issue-2930 into master

Update webUI number of tasks

Jana Cupova • 10 months ago

4c7ccac

www/kojiweb/tasks.chtml

file modified

+16 -2

		`@@ -126,7 +126,14 @@`
		`<a href="tasks?start=#echo $taskStart + $taskRange#$util.passthrough_except($self)">>>></a>`
		`#end if`
		`#else`
		`- <strong>Tasks #echo $taskStart + 1 # through #echo $taskStart + $taskCount#</strong>`
		`+ <form class="pageJump" action="">`
		`+ Page:`
		`+ <select onchange="javascript: window.location = 'tasks?start=' + this.value * $taskRange + '$util.passthrough_except($self)';">`
		`+ <option value="0"#if 0 == $taskCurrentPage then ' selected="selected"' else ''#>#echo 1#</option>`
		`+ <option value="1"#if 1 == $taskCurrentPage then ' selected="selected"' else ''#>#echo "load more"#</option>`
		`+ </select>`
		`+ </form>`
		`+ <strong>Tasks #echo $taskStart + 1 # through #echo $taskStart + $taskCount# of ???</strong>`
		`<a href="tasks?start=$taskRange$util.passthrough_except($self)">>>></a>`
		`#end if`
		`</td>`
		`@@ -190,7 +197,14 @@`
		`<a href="tasks?start=#echo $taskStart + $taskRange#$util.passthrough_except($self)">>>></a>`
		`#end if`
		`#else`
		`- <strong>Tasks #echo $taskStart + 1 # through #echo $taskStart + $taskCount#</strong>`
		`+ <form class="pageJump" action="">`
		`+ Page:`
		`+ <select onchange="javascript: window.location = 'tasks?start=' + this.value * $taskRange + '$util.passthrough_except($self)';">`
		`+ <option value="0"#if 0 == $taskCurrentPage then ' selected="selected"' else ''#>#echo 1#</option>`
		`+ <option value="1"#if 1 == $taskCurrentPage then ' selected="selected"' else ''#>#echo "load more"#</option>`
		`+ </select>`
		`+ </form>`
		`+ <strong>Tasks #echo $taskStart + 1 # through #echo $taskStart + $taskCount# of ???</strong>`
		`<a href="tasks?start=$taskRange$util.passthrough_except($self)">>>></a>`
		`#end if`
		`</td>`

jcupova commented 10 months ago

Fixes: https://pagure.io/koji/issue/2930

rebased onto 388686d81e9595439d8b07326f5d7e4dab78e19c

10 months ago

rebased onto 977d8c94da420dda3d343568feb922b90112433b

10 months ago

rebased onto 4c7ccac

10 months ago

tkopecek commented 10 months ago

:thumbsup:

mikem commented 10 months ago

I'm tempted to say we should unify this with the other pageJump form, but that's probably more trouble than it's worth. This looks fine and works on my end.

:thumbsup: