Learn more about these different git repos.
Other Git URLs
No commits found
Fixes: https://pagure.io/koji/issue/1217
when buildInfo is a dict with nvr like
buildInfo
{'name': 'N', 'version': 'V', 'release': 'R'}
it is still a valid input to trigger get_build(). Maybe checking if extra is present when it is a dict is better?
get_build()
extra
once get_build_type() get optimized, this line could be
get_build_type()
btypeinfo = get_build_type(kws['info'])
to save one get_build() call
rebased onto b30904e2880e27eace2f8d50759c6d6733ef1c7c
@julian8628 fixed
... or not 'extra' in buildInfo - most extra could be there and could be empty.
or not 'extra' in buildInfo
Shouldn't we return all btypes? @julian8628?
oh, yes. it should be all btypes
rebased onto 57b30d80455b5e1fa8245ea13676d802aa87feb2
@tkopecek @julian8628 fixed
maybe 'build_types' or 'build types' to indicate it is a dict?
otherwise, :thumbsup:
rebased onto cea2cca05581ed325682da028d165cee3252d3d1
Metadata Update from @julian8628: - Pull-request tagged with: testing-ready
Can we just name this "btypes" instead of "build types"? The term "btype" means something specifically in Koji.
EDIT: Ok, I read get_build_type() and I see that can return multiple types, so plural is right.
EDIT2: I'm wondering if all messaging systems support a space character in a header (like "build type")
rebased onto 3018bf6
ok, let's use btypes :)
@ktdreyer fixed
LGTM, thanks!
Metadata Update from @mfilip: - Pull-request tagged with: testing-done
Commit 9b45805 fixes this pull-request
Pull-Request has been merged by tkopecek
Fixes: https://pagure.io/koji/issue/1217