#2934 Add btype to protonmsg
Merged 2 years ago by tkopecek. Opened 2 years ago by jcupova.
jcupova/koji issue-1217  into  master

No commits found

when buildInfo is a dict with nvr like

{'name': 'N',
  'version': 'V',
  'release': 'R'}

it is still a valid input to trigger get_build().
Maybe checking if extra is present when it is a dict is better?

once get_build_type() get optimized, this line could be

btypeinfo = get_build_type(kws['info'])

to save one get_build() call

rebased onto b30904e2880e27eace2f8d50759c6d6733ef1c7c

2 years ago

... or not 'extra' in buildInfo - most extra could be there and could be empty.

Shouldn't we return all btypes? @julian8628?

oh, yes. it should be all btypes

rebased onto 57b30d80455b5e1fa8245ea13676d802aa87feb2

2 years ago

maybe 'build_types' or 'build types' to indicate it is a dict?

rebased onto cea2cca05581ed325682da028d165cee3252d3d1

2 years ago

Metadata Update from @julian8628:
- Pull-request tagged with: testing-ready

2 years ago

Can we just name this "btypes" instead of "build types"? The term "btype" means something specifically in Koji.

EDIT: Ok, I read get_build_type() and I see that can return multiple types, so plural is right.

EDIT2: I'm wondering if all messaging systems support a space character in a header (like "build type")

rebased onto 3018bf6

2 years ago

ok, let's use btypes :)

@ktdreyer fixed

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

2 years ago

Commit 9b45805 fixes this pull-request

Pull-Request has been merged by tkopecek

2 years ago
Metadata