PR#2912: dist-repo takes inherited arch when arch is not set - koji

koji

#2912 dist-repo takes inherited arch when arch is not set

Merged 2 years ago by tkopecek. Opened 2 years ago by jcupova.

jcupova/koji issue-2805 into master

No commits found

jcupova commented 2 years ago

Fixes: https://pagure.io/koji/issue/2805

tkopecek commented on line 5 of cli/koji_cli/commands.py 2 years ago

It could be simplified to if taginfo['arches']

tkopecek commented 2 years ago

1) That cycle should stop on first tag which has any arch.
2) There is a whole second branch (when user specifies some arch) which compares that arch again against taginfo. This should use same test. I would place whole inheritance check before the "if" and have something like "allowed_archs" which can be used in both parts.

rebased onto 7dc4444c14d5f0d58199118dd470c69edfa45e60

2 years ago

rebased onto 9e0fbfc150e24a033fcaa5b4eb98c5a65e5a8f25

2 years ago

rebased onto 1c67966

2 years ago