PR#291: Missing --can-fail option for spin-appliance - koji

koji

#291 Missing --can-fail option for spin-appliance

Merged 7 years ago by mikem. Opened 7 years ago by tkopecek.

tkopecek/koji missing-option into master

make optional_arches optional

Tomas Kopecek • 7 years ago

919d8b2

cli/koji

file modified

+2 -1

		`@@ -5860,7 +5860,8 @@`
		`print`

		`hub_opts = {}`
		`- hub_opts['optional_arches'] = task_opts.optional_arches.split(',')`
		`+ if hasattr(task_opts, 'optional_arches'):`
		`+ hub_opts['optional_arches'] = task_opts.optional_arches.split(',')`
		`passthru_opts = [`
		`'format', 'install_tree_url', 'isoname', 'ksurl',`
		`'ksversion', 'release', 'repo', 'scratch', 'skip_tag',`

tkopecek commented 7 years ago

Missing option causes spin-appliance to fail.

mikem commented 7 years ago

it was omitted because spin-appliance is deprecated

tkopecek commented 7 years ago

Yes, but it is now failing on any call of this method. So, spin-appliance is completely unusable. Options: 1) this PR 2) remove spin-appliance completely.

mikem commented 7 years ago

Option 3: don't require this option in _build_image:

@@ -5860,7 +5860,8 @@ def _build_image(options, task_opts, session, args, img_type):
         print

     hub_opts = {}
-    hub_opts['optional_arches'] = task_opts.optional_arches.split(',')
+    if hasattr(task_opts, 'optional_arches'):
+        hub_opts['optional_arches'] = task_opts.optional_arches.split(',')
     passthru_opts = [
         'format', 'install_tree_url', 'isoname', 'ksurl',
         'ksversion', 'release', 'repo', 'scratch', 'skip_tag',

tkopecek commented 7 years ago

Looks good - PR changed to this.

11 new commits added