PR#2784: Tolerate floats in metadata timestamps - koji

koji

#2784 Tolerate floats in metadata timestamps

Merged 3 years ago by tkopecek. Opened 3 years ago by alexi.

alexi/koji issue_2783 into master

Tolerate floats in metadata timestamps

Alex Iribarren • 3 years ago

5ab45cd

util/kojira

file modified

+1 -1

		`@@ -460,7 +460,7 @@`
		`r = requests.get(arch_url, timeout=5)`
		`root = ElementTree.fromstring(r.text)`
		`ts_elements = root.iter('{http://linux.duke.edu/metadata/repo}timestamp')`
		`- arch_ts = max([int(child.text) for child in ts_elements])`
		`+ arch_ts = max([round(float(child.text)) for child in ts_elements])`
		`self.external_repo_ts[arch_url] = arch_ts`
		`max_ts = max(max_ts, arch_ts)`
		`except Exception:`

alexi commented 3 years ago

Fixes #2783.

tkopecek commented 3 years ago

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

3 years ago

alexi commented 3 years ago

#2785 has already been merged, so I guess this can be closed?

Edited 3 years ago by alexi

tkopecek commented 3 years ago

No, I've just closed mine without merging as I've noticed yours.

tkopecek commented 3 years ago

Anyway, I was thinking about just float conversion. We can miss some updates (very hypothetically). If I've 123 timestamp for koji's repo and and external repo is 123.45 it will be ignored.

alexi commented 3 years ago

I added the round in case anything else depended on the timestamp being an int, although it didn't look like it would be an issue. Anyway, float(child.text) should be fine.