#2661 web: add comment explaining null start_time values
Merged 3 years ago by tkopecek. Opened 3 years ago by ktdreyer.
ktdreyer/koji www-start-time  into  master

file modified
+5
@@ -1300,6 +1300,11 @@ 

          if field not in values:

              values[field] = None

  

+     # We added the start_time field in 2015 as part of Koji's content

+     # generator feature. Builds before that point have a null value for

+     # start_time. Fall back to creation_ts in those cases.

+     # Currently new_build() has data.setdefault('start_time', 'NOW'), so all

+     # recent builds should have a value for the field.

      values['start_ts'] = build.get('start_ts') or build['creation_ts']

      # the build start time is not accurate for maven and win builds, get it from the

      # task start time instead

Explain why kojiweb falls back to creation_ts when start_ts is unavailable. Thanks MikeM for the explanation.

Metadata Update from @julian8628:
- Pull-request tagged with: doc, no_qe

3 years ago

Commit ffa0912 fixes this pull-request

Pull-Request has been merged by tkopecek

3 years ago
Metadata