PR#2654: cli: hide import-sig --write option - koji

koji

#2654 cli: hide import-sig --write option

Merged 3 years ago by tkopecek. Opened 3 years ago by tkopecek.

tkopecek/koji issue2620 into master

update help text

Tomas Kopecek • 3 years ago

932994f

cli: hide import-sig --write option

Tomas Kopecek • 3 years ago

e63508f

cli/koji_cli/commands.py

file modified

+2 -3

		`@@ -1450,13 +1450,12 @@`


		`def handle_import_sig(goptions, session, args):`
		`- "[admin] Import signatures into the database"`
		`+ "[admin] Import signatures into the database and write signed RPMs"`
		`usage = _("usage: %prog import-sig [options] <package> [<package> ...]")`
		`parser = OptionParser(usage=get_usage_str(usage))`
		`parser.add_option("--with-unsigned", action="store_true",`
		`help=_("Also import unsigned sig headers"))`
		`- parser.add_option("--write", action="store_true",`
		`- help=_("Also write the signed copies"))`
		`+ parser.add_option("--write", action="store_true", help=SUPPRESS_HELP)`
		`parser.add_option("--test", action="store_true",`
		`help=_("Test mode -- don't actually import"))`
		`(options, args) = parser.parse_args(args)`

tests/test_cli/test_import_sig.py

file modified

-1

		`@@ -276,7 +276,6 @@`
		`Options:`
		`-h, --help show this help message and exit`
		`--with-unsigned Also import unsigned sig headers`
		`- --write Also write the signed copies`
		`--test Test mode -- don't actually import`
		`""" % self.progname)`

tkopecek commented 3 years ago

It is no more used, hide it from the user.

Fixes: https://pagure.io/koji/issue/2620

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

3 years ago

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

3 years ago

ktdreyer commented 3 years ago

Want to update the help text as well?

 def handle_import_sig(goptions, session, args):
-    "[admin] Import signatures into the database"
+    "[admin] Import signatures into the database and write signed RPMs"

1 new commit added