#2653 web: more accessible task colors/icons
Merged a year ago by tkopecek. Opened a year ago by tkopecek.
tkopecek/koji issue2583  into  master

@@ -19,6 +19,7 @@ 

        #set $childState = $util.taskState($child.state)

        <span class="treeBranch">

          <span class="treeLabel">

+           <span class="task$childState">$util.imageTag($childState)</span>

            <a href="taskinfo?taskID=$child.id" class="task$childState" title="$childState">$koji.taskLabel($child)</a>

          </span>

        </span>
@@ -163,6 +164,8 @@ 

        <th>Descendants</th>

        <td class="tree">

          #if $len($descendents[$str($task.id)]) > 0

+         #set $taskState = $util.taskState($task.state)

+         <span class="task$taskState">$util.imageTag($taskState)</span>

          <span class="root">$task.method</span>

          #end if

          $printChildren($task.id, $descendents)

file modified
+7 -7
@@ -181,21 +181,21 @@ 

  }

  

  td.complete {

-     color: #0c0;

+     color: #008000;

  }

  

  td.deleted,

  td.failed,

  td.canceled {

-     color: #c00;

+     color: #ff0000;

  }

  

  td.false {

-     color: #c00;

+     color: #ff0000;

  }

  

  td.true {

-     color: #0c0;

+     color: #008000;

  }

  

  img.sort {
@@ -392,11 +392,11 @@ 

  }

  

  .taskopen {

-     color: #f60;

+     color: #ff8c00;

  }

  

  .taskclosed, .repoready {

-     color: #0c0;

+     color: #008000;

  }

  

  .taskcanceled, .repoexpired {
@@ -408,7 +408,7 @@ 

  }

  

  .taskfailed, .repodeleted, .repoproblem {

-     color: #c00;

+     color: #ff0000;

  }

  

  a.help {

More bright colors + icons on taskinfo page.

screenshot added to issue (PRs don't allow attachments)

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

a year ago

I see the color changes are realted to tasks only, but there are still some occurences of the 'old' colors in the stylesheet - which feel inconsistent when seen on the web (e.g. build state). Do you maybe want to replace all the colors with the new ones?

1 new commit added

  • update task colors
a year ago

Metadata Update from @jobrauer:
- Pull-request tagged with: testing-done

a year ago

Commit 019a136 fixes this pull-request

Pull-Request has been merged by tkopecek

a year ago