PR#2653: web: more accessible task colors/icons - koji

koji

#2653 web: more accessible task colors/icons

Merged 3 years ago by tkopecek. Opened 3 years ago by tkopecek.

tkopecek/koji issue2583 into master

update task colors

Tomas Kopecek • 3 years ago

c3e727d

web: more accessible task colors/icons

Tomas Kopecek • 3 years ago

944db3f

www/kojiweb/taskinfo.chtml

file modified

		`@@ -19,6 +19,7 @@`
		`#set $childState = $util.taskState($child.state)`
		`<span class="treeBranch">`
		`<span class="treeLabel">`
		`+ <span class="task$childState">$util.imageTag($childState)</span>`
		`<a href="taskinfo?taskID=$child.id" class="task$childState" title="$childState">$koji.taskLabel($child)</a>`
		`</span>`
		`</span>`
		`@@ -163,6 +164,8 @@`
		`<th>Descendants</th>`
		`<td class="tree">`
		`#if $len($descendents[$str($task.id)]) > 0`
		`+ #set $taskState = $util.taskState($task.state)`
		`+ <span class="task$taskState">$util.imageTag($taskState)</span>`
		`<span class="root">$task.method</span>`
		`#end if`
		`$printChildren($task.id, $descendents)`

www/static/koji.css

file modified

+7 -7

		`@@ -181,21 +181,21 @@`
		`}`

		`td.complete {`
		`- color: #0c0;`
		`+ color: #008000;`
		`}`

		`td.deleted,`
		`td.failed,`
		`td.canceled {`
		`- color: #c00;`
		`+ color: #ff0000;`
		`}`

		`td.false {`
		`- color: #c00;`
		`+ color: #ff0000;`
		`}`

		`td.true {`
		`- color: #0c0;`
		`+ color: #008000;`
		`}`

		`img.sort {`
		`@@ -392,11 +392,11 @@`
		`}`

		`.taskopen {`
		`- color: #f60;`
		`+ color: #ff8c00;`
		`}`

		`.taskclosed, .repoready {`
		`- color: #0c0;`
		`+ color: #008000;`
		`}`

		`.taskcanceled, .repoexpired {`
		`@@ -408,7 +408,7 @@`
		`}`

		`.taskfailed, .repodeleted, .repoproblem {`
		`- color: #c00;`
		`+ color: #ff0000;`
		`}`

		`a.help {`

tkopecek commented 3 years ago

Fixes: https://pagure.io/koji/issue/2583

tkopecek commented 3 years ago

More bright colors + icons on taskinfo page.

tkopecek commented 3 years ago

screenshot added to issue (PRs don't allow attachments)

julian8628 commented 3 years ago

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

3 years ago

jobrauer commented 3 years ago

I see the color changes are realted to tasks only, but there are still some occurences of the 'old' colors in the stylesheet - which feel inconsistent when seen on the web (e.g. build state). Do you maybe want to replace all the colors with the new ones?

1 new commit added