PR#2608: cli: support download-build --type=remote-sources - koji

koji

#2608 cli: support download-build --type=remote-sources

Merged 3 years ago by tkopecek. Opened 3 years ago by ktdreyer.

ktdreyer/koji download-remote-sources into master

No commits found

ktdreyer commented 3 years ago

Prior to this change, koji download-build --type=remote-sources failed with an AssertionError.

Add support for OSBS's cachito remote-sources btype.

ktdreyer commented 3 years ago

Further improvements we could make:

Medium-term: We should raise NotImplementedError with the btype string that we don't support, rather than assert False, so users can understand a bit more about what went wrong: PR #2610

Long-term: We can probably generalize this, because all content generators should be using the btype name (archive['btype']) for the directory name to PathInfo's typedir() method. That would let us remove this remote-sources condition and just handle all content generators the same way.

Edited 3 years ago by ktdreyer