PR#2520: Fix PR#2347 - make "not wait" work again - koji

koji

#2520 Fix PR#2347 - make "not wait" work again

Closed 2 years ago by lon. Opened 3 years ago by lon.

lon/koji master into master

Fix PR#2347 - make "not wait" work again

Lon Hohberger • 3 years ago

7150649

cli/koji_cli/commands.py

file modified

+1 -1

		`@@ -5887,7 +5887,7 @@`
		`if not options.quiet:`
		`print("Created task: %d" % task_id)`
		`print("Task info: %s/taskinfo?taskID=%s" % (options.weburl, task_id))`
		`- if task_opts.wait or (task_opts.wait is None and not _running_in_bg()):`
		`+ if task_opts.wait:`
		`session.logout()`
		`return watch_tasks(session, [task_id], quiet=options.quiet)`

lon commented 3 years ago

Prior to PR#2347, koji would not wait for image
and indirectionimage builds even if --wait was
specified. After PR#2347, koji always waits,
even when --wait is NOT specified.

According to the CLI docs, "wait" should happen
regardless of whether we've decided to run in
the background, thus, checking this is superfluous.

Signed-off-by: Lon Hohberger lhh@redhat.com