koji

Clone

#2470 koji-gc: log error if build can't be deleted
Merged 3 years ago by tkopecek. Opened 3 years ago by tkopecek.
tkopecek/koji issue2469  into  master

file modified
+1 -1 
@@ -969,7 +969,7 @@ 
 

              else:
 

                  print("Deleting untagged build: %s" % nvr)
 

                  try:
 

-                     session.deleteBuild(build_id, strict=False)
 

+                     session.deleteBuild(build_id, strict=True)
 

                  except (six.moves.xmlrpc_client.Fault, koji.GenericError) as e:
 

                      print("Warning: deletion failed: %s" % e)
 

                      # server issue

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready
3 years ago

:thumbsup:

Btw, there is no any information when doing deleteBuild(deleted_build, ...), should we skip _delete_build if the build has been deleted?

I think we should - but it should be a separate issue (as it is changing API behaviour not koji-gc)

Created #2475

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done
3 years ago

Commit fab382f fixes this pull-request

Pull-Request has been merged by tkopecek
3 years ago
Changes Summary 1
+1 -1
file changed
util/koji-gc
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.