PR#2417: kojid: waitrepo on deleted tag - koji

koji

#2417 kojid: waitrepo on deleted tag

Merged 3 years ago by tkopecek. Opened 3 years ago by tkopecek.

tkopecek/koji issue2414 into master

kojid: more meaningful error message

Tomas Kopecek • 3 years ago

6f5f2ab

kojid: waitrepo on deleted tag

Clément Bénier • 3 years ago

fac7bec

builder/kojid

file modified

		`@@ -6339,6 +6339,13 @@`
		`last_repo = None`

		`while True:`
		`+ try:`
		`+ taginfo = self.session.getTag(tag, strict=True)`
		`+ except koji.GenericError:`
		`+ self.logger.debug("Tag %s got lost while waiting for newrepo", tag)`
		`+ raise koji.GenericError("Unsuccessfully waited %s for %s repo. "`
		`+ "Tag was probably deleted meanwhile." %`
		`+ (koji.util.duration(start), tag))`
		`repo = self.session.getRepo(taginfo['id'])`
		`if repo and repo != last_repo:`
		`if builds:`

tkopecek commented 3 years ago

Expanded PR #2416
Fixes: https://pagure.io/koji/issue/2414

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

3 years ago

julian8628 commented 3 years ago

:thumbsup:

mikem commented 3 years ago

self.logger.debug("Tag %s got lost while waiting for newrepo" % tag)

A minor thing, but we should avoid % expansion in logger calls. The call will do the expansion for you if you just pass the parameters as arguments.

For that matter, the log message seems redundant as the following error will also show in the logs.

An even more minor thing, but the extra space in the except clause is distracting :wink:

rebased onto fac7bec

3 years ago