#2417 kojid: waitrepo on deleted tag
Merged 2 years ago by tkopecek. Opened 2 years ago by tkopecek.
tkopecek/koji issue2414  into  master

file modified
+7
@@ -6339,6 +6339,13 @@ 

          last_repo = None

  

          while True:

+             try:

+                 taginfo = self.session.getTag(tag, strict=True)

+             except koji.GenericError:

+                 self.logger.debug("Tag %s got lost while waiting for newrepo", tag)

+                 raise koji.GenericError("Unsuccessfully waited %s for %s repo. "

+                                         "Tag was probably deleted meanwhile." %

+                                         (koji.util.duration(start), tag))

              repo = self.session.getRepo(taginfo['id'])

              if repo and repo != last_repo:

                  if builds:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

2 years ago

self.logger.debug("Tag %s got lost while waiting for newrepo" % tag)

A minor thing, but we should avoid % expansion in logger calls. The call will do the expansion for you if you just pass the parameters as arguments.

For that matter, the log message seems redundant as the following error will also show in the logs.

An even more minor thing, but the extra space in the except clause is distracting :wink:

rebased onto fac7bec

2 years ago

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

2 years ago

1 new commit added

  • kojira: parallelize rmtree
2 years ago

2 new commits added

  • kojid: more meaningful error message
  • kojid: waitrepo on deleted tag
2 years ago

pretty please pagure-ci rebuild

2 years ago

Commit ace354a fixes this pull-request

Pull-Request has been merged by tkopecek

2 years ago