#2397 kojira: remove unused delete_batch_size
Merged 3 years ago by tkopecek. Opened 3 years ago by julian8628.
julian8628/koji kojira-delete-batch-size  into  master

file modified
-4
@@ -81,10 +81,6 @@ 

      Overall limit on running tasks is set here. It involves all

      ``newRepo`` tasks spawned by kojira and also by other users.

  

- ``delete_batch_size = 3``

-     How many repos are being removed from disk in one iteration. This

-     generally doesn't need to be changed.

- 

  ``check_external_repos = false``

      If True, monitor external repos and trigger the appropriate Koji repo

      regenerations when they change.

file modified
+3 -5
@@ -1091,7 +1091,6 @@ 

                  'max_repo_tasks': 4,

                  'max_repo_tasks_maven': 2,

                  'repo_tasks_limit': 10,

-                 'delete_batch_size': 3,

                  'deleted_repo_lifetime': 7 * 24 * 3600,

                  # XXX should really be called expired_repo_lifetime

                  'dist_repo_lifetime': 7 * 24 * 3600,
@@ -1106,15 +1105,14 @@ 

      if config.has_section(section):

          int_opts = ('deleted_repo_lifetime', 'max_repo_tasks', 'repo_tasks_limit',

                      'retry_interval', 'max_retries', 'offline_retry_interval',

-                     'max_delete_processes', 'max_repo_tasks_maven',

-                     'delete_batch_size', 'dist_repo_lifetime', 'sleeptime',

-                     'recent_tasks_lifetime')

+                     'max_delete_processes', 'max_repo_tasks_maven', 'dist_repo_lifetime',

+                     'sleeptime', 'recent_tasks_lifetime')

          str_opts = ('topdir', 'server', 'user', 'password', 'logfile', 'principal', 'keytab',

                      'cert', 'ca', 'serverca', 'debuginfo_tags', 'queue_file',

                      'source_tags', 'separate_source_tags', 'ignore_tags')  # FIXME: remove ca here

          bool_opts = ('verbose', 'debug', 'ignore_stray_repos', 'offline_retry',

                       'no_ssl_verify', 'check_external_repos')

-         legacy_opts = ('with_src')

+         legacy_opts = ('with_src', 'delete_batch_size')

          for name in config.options(section):

              if name in int_opts:

                  defaults[name] = config.getint(section, name)

Metadata Update from @julian8628:
- Pull-request tagged with: no_qe

3 years ago

It should be moved to legacy_opts

1 new commit added

  • add delete_batch_size into legacy_opts
3 years ago

rebased onto 2aa7ff6

3 years ago

Commit d561f8d fixes this pull-request

Pull-Request has been merged by tkopecek

3 years ago