koji

Clone

#2364 cli clone-tag - get srctag info with event
Merged 3 years ago by mikem. Opened 3 years ago by julian8628.
julian8628/koji issue/2101  into  master

file modified
+1 -1 
@@ -3410,7 +3410,7 @@ 
 

          print(_("Cloning at event %(id)i (%(timestr)s)") % event)
 

  

      # store tags.
 

-     srctag = session.getTag(args[0])
 

+     srctag = session.getTag(args[0], event=event.get('id'))
 

      dsttag = session.getTag(args[1])
 

      if not srctag:
 

          parser.error(_("Unknown src-tag: %s" % args[0]))

file modified
+2 -2 
@@ -211,7 +211,7 @@ 
 

          handle_clone_tag(self.options, self.session, args)
 

          self.activate_session.assert_called_once()
 

          self.session.assert_has_calls([call.hasPerm('admin'),
 

-                                        call.getTag('src-tag'),
 

+                                        call.getTag('src-tag', event=None),
 

                                         call.getTag('dst-tag'),
 

                                         call.createTag('dst-tag',
 

                                                        arches='arch1 arch2',
 
@@ -485,7 +485,7 @@ 
 

          handle_clone_tag(self.options, self.session, args)
 

          self.activate_session.assert_called_once()
 

          self.session.assert_has_calls([call.hasPerm('admin'),
 

-                                        call.getTag('src-tag'),
 

+                                        call.getTag('src-tag', event=None),
 

                                         call.getTag('dst-tag'),
 

                                         call.listPackages(event=None,
 

                                                           inherited=True,

So that tag config and extra honor event for clone-tag cmd

fixes: #2101

Metadata Update from @julian8628:
- Pull-request tagged with: testing-ready
3 years ago

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done
3 years ago

Commit 43db33e fixes this pull-request

Pull-Request has been merged by mikem
3 years ago
Changes Summary 2
+1 -1
file changed
cli/koji_cli/commands.py
+2 -2
file changed
tests/test_cli/test_clone_tag.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.