PR#2184: kojid: update shebang of mergerepos to python3 - koji

koji

#2184 kojid: update shebang of mergerepos to python3

Closed 3 years ago by julian8628. Opened 3 years ago by julian8628.

julian8628/koji py3-builder into master

kojid: update shebang of mergerepos to python3

Yuming Zhu • 3 years ago

e296cbb

builder/Makefile

file modified

+1 -1

		`@@ -7,7 +7,7 @@`
		`@echo "nothing to make. try make install"`

		`clean:`
		`- rm -f .o .so .pyc ~ kojidc`
		`+ rm -f .o .so .pyc ~ kojidc mergereposc`
		`rm -rf __pycache__`

koji.spec

file modified

+2 -2

		`@@ -469,8 +469,8 @@`
		`%if 0%{py3_support} > 1`
		`make DESTDIR=$RPM_BUILD_ROOT PYTHON=%{__python3} %{?install_opt} install`
		`# alter python interpreter in koji CLI`
		`- scripts='%{_bindir}/koji %{_sbindir}/kojid %{_sbindir}/kojira %{_sbindir}/koji-shadow`
		`- %{_sbindir}/koji-gc %{_sbindir}/kojivmd %{_sbindir}/koji-sweep-db'`
		`+ scripts='%{_bindir}/koji %{_sbindir}/kojid %{_libexecdir}/kojid/mergerepos %{_sbindir}/kojira`
		`+ %{_sbindir}/koji-shadow %{_sbindir}/koji-gc %{_sbindir}/kojivmd %{_sbindir}/koji-sweep-db'`
		`for fn in $scripts ; do`
		`sed -i 's\|#!/usr/bin/python2\|#!/usr/bin/python3\|' $RPM_BUILD_ROOT$fn`
		`done`

julian8628 commented 3 years ago

fixes: #2183

julian8628 commented 3 years ago

@mikem @tkopecek @lbalhar

ignatenkobrain commented 3 years ago

:thumbsdown: there is no point in doing this since it won't work... it depends on yum and it is py2-only.

ngompa commented 3 years ago

:thumbsdown:

ngompa commented 3 years ago

We should delete this code and just hard-depend on mergerepo_c.

julian8628 commented 3 years ago

Oh, apologize for that I didn't check the python3 compatibility of this script

The simple merge mode is not supported by mergerepo_c I think.

So do we really want to remove this functionality?

Is it worthy to change this script with the replacement from yum, rpmUtil to dnf, libdnf, hawkey, etc ?

ngompa commented 3 years ago

All merge modes are supported by mergerepo_c. The Koji "simple" merge mode is activated via the --koji switch.

julian8628 commented 3 years ago

PR #2185 to delete mergerepos

tkopecek commented 3 years ago

No, it is not the same AFAIK
simple: mergererepos --simple - we can't do that with mergerepos_c yet.
koji: mergerepos_c --koji
bare: mergerepos_c --pkgorigins --all (or mergerepos --koji)

The question is, if bare mode is not usable in place of simple. The difference is that bare ignores blocklist. @mikem is there any other significant difference now?