PR#2168: turn off checking external repos by default - koji

koji

#2168 turn off checking external repos by default

Merged 4 years ago by tkopecek. Opened 4 years ago by tkopecek.

tkopecek/koji issue2159 into master

adjust grammar

Mike McLean • 4 years ago

08e52da

turn off checking external repos by default

Tomas Kopecek • 4 years ago

3aca7b4

docs/source/utils.rst

file modified

		`@@ -85,6 +85,12 @@`
		`How many repos are being removed from disk in one iteration. This`
		`generally doesn't need to be changed.`

		+ ``check_external_repos = false``
		`+ If True, monitor external repos and trigger the appropriate Koji repo`
		`+ regenerations when they change.`
		`+ Note that you need to have your database set to use UTC, as otherwise`
		`+ you can end with weird behaviour. For details see`
		`+ https://pagure.io/koji/issue/2159`

		`Garbage Collector`
		`-----------------`

util/kojira

file modified

+1 -1

		`@@ -1030,7 +1030,7 @@`
		`'deleted_repo_lifetime': 7 * 24 * 3600,`
		`# XXX should really be called expired_repo_lifetime`
		`'dist_repo_lifetime': 7 * 24 * 3600,`
		`- 'check_external_repos': True,`
		`+ 'check_external_repos': False,`
		`'recent_tasks_lifetime': 600,`
		`'sleeptime': 15,`
		`'cert': None,`

util/kojira.conf

file modified

		`@@ -51,3 +51,10 @@`

		`; ignored repositories according to glob. Multiple masks separated by space.`
		`; ignore_tags =`
		`+`
		`+`
		`+ ; Monitor external repos and trigger the appropriate Koji repo regenerations`
		`+ ; when they change. Note that you need to have your database set to use UTC,`
		`+ ; as otherwise you can end with weird behaviour. For details see`
		`+ ; https://pagure.io/koji/issue/2159`
		`+ ; check_external_repos = false`

tkopecek commented 4 years ago

Fixes: https://pagure.io/koji/issue/2159

mikem commented 4 years ago

Looks good. Minor grammar adjustment here:
https://github.com/mikem23/koji-playground/commits/pagure/pr/2168

Otherwise :thumbsup:

ngompa commented 4 years ago

What does this feature do?

tkopecek commented 4 years ago

@ngompa It is a followup of #516 - monitoring external repos in kojira. If external repo content changes, newRepo is triggerred for all repos whose have it linked.

ngompa commented 4 years ago

Oh nice!

ngompa commented 4 years ago

:thumbsup: with @mikem's grammar fixes. :100:

1 new commit added