PR#2105: always set utf8 pg client encoding - koji

koji

#2105 always set utf8 pg client encoding

Merged 4 years ago by tkopecek. Opened 4 years ago by tkopecek.

tkopecek/koji issue2104 into master

Tomas Kopecek • 4 years ago

6430636

koji/db.py

file modified

		`@@ -189,6 +189,7 @@`
		`opts = {}`
		`try:`
		`conn = psycopg2.connect(**opts)`
		`+ conn.set_client_encoding('UTF8')`
		`except Exception:`
		`logger.error(''.join(traceback.format_exception(*sys.exc_info())))`
		`raise`

tkopecek commented 4 years ago

It breaks db tests for now, I'll fix them, if we agree that we want to use this fix.

mikem commented 4 years ago

I'm questioning the extent to which full unicode makes sense in a name field. I've filed #2117 for a larger discussion.

tkopecek commented 4 years ago

@mikem Yes, but this is relevant to any unicode entering the db, so e.g. extras in importCG

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

4 years ago

mikem commented 4 years ago

:thumbsup:

pretty please pagure-ci rebuild

4 years ago

tkopecek commented 4 years ago

Commit cb3e530 fixes this pull-request

Pull-Request has been merged by tkopecek

4 years ago

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

4 years ago

Metadata

Assignee

None

Tags

Flags

jenkins

success (100%)

Build #1518 successful (commit: 6430636b)

4 years ago

jenkins

failure

Build #1491 failed (commit: 6430636b)

4 years ago

Changes Summary 1

+1 -0

file changed

koji/db.py

koji

Source Code

Documentation

#2105 always set utf8 pg client encoding Merged 4 years ago by tkopecek. Opened 4 years ago by tkopecek. tkopecek/koji issue2104 into master

Metadata

testing-ready testing-done

Flags

Changes Summary 1

#2105 always set utf8 pg client encoding

Merged 4 years ago by tkopecek. Opened 4 years ago by tkopecek.

tkopecek/koji issue2104 into master