PR#1949: don't allow setTaskPriority on closed task - koji - Pagure.io

koji

#1949 don't allow setTaskPriority on closed task

Merged 4 years ago by tkopecek. Opened 4 years ago by tkopecek.

tkopecek/koji issue1153 into master

don't allow setTaskPriority on closed task

Tomas Kopecek • 4 years ago

62bbec0

cli/koji_cli/commands.py

file modified

+4 -1

		`@@ -6102,7 +6102,10 @@`
		`activate_session(session, goptions)`

		`for task_id in tasks:`
		`- session.setTaskPriority(task_id, options.priority, options.recurse)`
		`+ try:`
		`+ session.setTaskPriority(task_id, options.priority, options.recurse)`
		`+ except koji.GenericError:`
		`+ warn("Can't update task priority on closed task: %s" % task_id)`


		`def handle_list_tasks(goptions, session, args):`

hub/kojihub.py

file modified

+2

		`@@ -10625,6 +10625,8 @@`
		`"""Set task priority"""`
		`context.session.assertPerm('admin')`
		`task = Task(task_id)`
		`+ if task.isFinished():`
		`+ raise koji.GenericError("Finished task's priority can't be updated")`
		`task.setPriority(priority, recurse=recurse)`

		`def listTagged(self, tag, event=None, inherit=False, prefix=None, latest=False, package=None, owner=None, type=None):`

tkopecek commented 4 years ago

Fixes: https://pagure.io/koji/issue/1153

rebased onto 62bbec0

4 years ago

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

4 years ago

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

4 years ago

julian8628 commented 4 years ago

:thumbsup:

tkopecek commented 4 years ago

Commit b5ca29f fixes this pull-request

Pull-Request has been merged by tkopecek

4 years ago

Metadata

Assignee

None

Tags

Changes Summary 2

file changed

cli/koji_cli/commands.py

file changed

Powered by Pagure 5.13.3

Documentation • File an Issue • About • SSH Hostkey/Fingerprint

© Red Hat, Inc. and others.