PR#1946: fix usage message for add-pkg - koji - Pagure.io

koji

#1946 fix usage message for add-pkg

Merged 4 years ago by tkopecek. Opened 4 years ago by tkopecek.

tkopecek/koji issue1212 into master

fix usage message for add-pkg

Tomas Kopecek • 4 years ago

31fd78d

cli/koji_cli/commands.py

file modified

+1 -1

		`@@ -320,7 +320,7 @@`

		`def handle_add_pkg(goptions, session, args):`
		`"[admin] Add a package to the listing for tag"`
		`- usage = _("usage: %prog add-pkg [options] <tag> <package> [<package> ...]")`
		`+ usage = _("usage: %prog add-pkg [options] --owner <owner> <tag> <package> [<package> ...]")`
		`parser = OptionParser(usage=get_usage_str(usage))`
		`parser.add_option("--force", action='store_true', help=_("Override blocks if necessary"))`
		`parser.add_option("--owner", help=_("Specify owner"))`

tests/test_cli/test_add_pkg.py

file modified

+2 -2

		`@@ -202,7 +202,7 @@`
		`actual_stdout = stdout.getvalue()`
		`actual_stderr = stderr.getvalue()`
		`expected_stdout = ''`
		`- expected_stderr = """Usage: %s add-pkg [options] <tag> <package> [<package> ...]`
		`+ expected_stderr = """Usage: %s add-pkg [options] --owner <owner> <tag> <package> [<package> ...]`
		`(Specify the --help global option for a list of other help options)`

		`%s: error: Please specify an owner for the package(s)`
		`@@ -239,7 +239,7 @@`
		`actual_stdout = stdout.getvalue()`
		`actual_stderr = stderr.getvalue()`
		`expected_stdout = ''`
		`- expected_stderr = """Usage: %s add-pkg [options] <tag> <package> [<package> ...]`
		`+ expected_stderr = """Usage: %s add-pkg [options] --owner <owner> <tag> <package> [<package> ...]`
		`(Specify the --help global option for a list of other help options)`

		`%s: error: Please specify a tag and at least one package`

tkopecek commented 4 years ago

Fixes: https://pagure.io/koji/issue/1212

Metadata Update from @tkopecek:
- Pull-request tagged with: doc, no_qe

4 years ago

Metadata Update from @tkopecek:
- Pull-request untagged with: doc, no_qe
- Pull-request tagged with: testing-ready

4 years ago

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

4 years ago

julian8628 commented 4 years ago

:thumbsup:

tkopecek commented 4 years ago

Commit e60252c fixes this pull-request

Pull-Request has been merged by tkopecek

4 years ago

Metadata

Assignee

None

Tags

Changes Summary 2

file changed

cli/koji_cli/commands.py

file changed

tests/test_cli/test_add_pkg.py

Powered by Pagure 5.13.3

Documentation • File an Issue • About • SSH Hostkey/Fingerprint

© Red Hat, Inc. and others.