PR#1919: expect, that hub is returning GM time - koji

koji

#1919 expect, that hub is returning GM time

Merged 2 years ago by tkopecek. Opened 2 years ago by tkopecek.

tkopecek/koji issue1915 into master

expect, that hub is returning GM time

Tomas Kopecek • 2 years ago

ff88d4a

www/kojiweb/taskinfo.chtml

file modified

+2 -2

		`@@ -2,7 +2,7 @@`
		`#from kojiweb import util`
		`#from six.moves.urllib.parse import quote`
		`#import cgi`
		`- #import time`
		`+ #import datetime`

		`#def printValue($key, $value, $sep=', ')`
		`#if $key in ('brootid', 'buildroot_id')`
		`@@ -343,7 +343,7 @@`
		`#set $end_ts = $task.completion_ts`
		`#end if`
		`#if not $end_ts`
		`- #set $end_ts = time.time()`
		`+ #set $end_ts = datetime.datetime.utcnow().timestamp()`
		`#end if`
		`<tr>`
		`<th title="From task's creation">Total time</th>`

tkopecek commented 2 years ago

Fixes: https://pagure.io/koji/issue/1915

tkopecek commented 2 years ago

Problem is, that timestamps are coming from DB. If DB's timezone is not set to GMT, we still can get weird times. @mikem Is it safe to assume, that it is in GMT? Should we emphasize it somewhere in installation docs?

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

2 years ago