#1841 continue instead of exiting
Merged 4 years ago by mikem. Opened 4 years ago by tkopecek.
tkopecek/koji issue1840  into  master

file modified
+2 -2
@@ -901,8 +901,8 @@ 

                  #accept this task)

                  bin_avail = avail.get(bin, [0])

                  if self.checkAvailDelay(task, bin_avail, our_avail):

-                         # decline for now and give the upper half a chance

-                         return False

+                     # decline for now and give the upper half a chance

+                     continue

                  #otherwise, we attempt to open the task

                  if self.takeTask(task):

                      return True

This goes way back. It was never right, but before the checkAvailDelay function this was how we implemented a delay for the lower half of the bin.

Now the logic is different and the delay is handled within checkAvailDelay without sleep or interruption. Too bad we didn't figure this out for PR#1176.

Anyway, looks like the right fix

:thumbsup:

This return has a worse impact since #1176 (in 1.17) because checkAvailDelay is much more likely trigger it than checkRelAvail was.

Commit a64cbdc fixes this pull-request

Pull-Request has been merged by mikem

4 years ago