#1775 clarify --ts usage
Merged 2 years ago by tkopecek. Opened 2 years ago by tkopecek.
tkopecek/koji issue1774  into  master

file modified
+8 -8
@@ -2486,7 +2486,7 @@ 

      parser.add_option("--sigs", action="store_true", help=_("Show signatures"))

      parser.add_option("--type", help=_("Show builds of the given type only.  Currently supported types: maven, win, image"))

      parser.add_option("--event", type='int', metavar="EVENT#", help=_("query at event"))

-     parser.add_option("--ts", type='int', metavar="TIMESTAMP", help=_("query at timestamp"))

+     parser.add_option("--ts", type='int', metavar="TIMESTAMP", help=_("query at last event before timestamp"))

      parser.add_option("--repo", type='int', metavar="REPO#", help=_("query at event for a repo"))

      (options, args) = parser.parse_args(args)

      if len(args) == 0:
@@ -2680,7 +2680,7 @@ 

      usage += _("\n(Specify the --help global option for a list of other help options)")

      parser = OptionParser(usage=usage)

      parser.add_option("--event", type='int', metavar="EVENT#", help=_("query at event"))

-     parser.add_option("--ts", type='int', metavar="TIMESTAMP", help=_("query at timestamp"))

+     parser.add_option("--ts", type='int', metavar="TIMESTAMP", help=_("query at last event before timestamp"))

      parser.add_option("--repo", type='int', metavar="REPO#", help=_("query at event for a repo"))

      parser.add_option("--show-blocked", action="store_true", dest="incl_blocked", help=_("Show blocked packages"))

      (options, args) = parser.parse_args(args)
@@ -2943,7 +2943,7 @@ 

      parser.add_option("--show-blocked", action="store_true", help=_("Show blocked packages"))

      parser.add_option("--show-dups", action="store_true", help=_("Show superseded owners"))

      parser.add_option("--event", type='int', metavar="EVENT#", help=_("query at event"))

-     parser.add_option("--ts", type='int', metavar="TIMESTAMP", help=_("query at timestamp"))

+     parser.add_option("--ts", type='int', metavar="TIMESTAMP", help=_("query at last event before timestamp"))

      parser.add_option("--repo", type='int', metavar="REPO#", help=_("query at event for a repo"))

      (options, args) = parser.parse_args(args)

      if len(args) != 0:
@@ -3378,8 +3378,8 @@ 

      parser.add_option('--inherit-builds', action='store_true',

              help=_("Include all builds inherited into the source tag into "

                     "the dest tag"))

-     parser.add_option('--ts', type='int',

-             help=_('Clone tag at a specific timestamp'))

+     parser.add_option('--ts', type='int', metavar="TIMESTAMP",

+             help=_('Clone tag at last event before specific timestamp'))

      parser.add_option('--event', type='int',

              help=_('Clone tag at a specific event'))

      parser.add_option('--repo', type='int',
@@ -4044,7 +4044,7 @@ 

      parser.add_option("--stop", help=_("Stop processing inheritance at this tag"))

      parser.add_option("--jump", help=_("Jump from one tag to another when processing inheritance"))

      parser.add_option("--event", type='int', metavar="EVENT#", help=_("query at event"))

-     parser.add_option("--ts", type='int', metavar="TIMESTAMP", help=_("query at timestamp"))

+     parser.add_option("--ts", type='int', metavar="TIMESTAMP", help=_("query at last event before timestamp"))

      parser.add_option("--repo", type='int', metavar="REPO#", help=_("query at event for a repo"))

      (options, args) = parser.parse_args(args)

      if len(args) != 1:
@@ -4850,7 +4850,7 @@ 

      usage += _("\n(Specify the --help global option for a list of other help options)")

      parser = OptionParser(usage=usage)

      parser.add_option("--event", type='int', metavar="EVENT#", help=_("query at event"))

-     parser.add_option("--ts", type='int', metavar="TIMESTAMP", help=_("query at timestamp"))

+     parser.add_option("--ts", type='int', metavar="TIMESTAMP", help=_("query at last event before timestamp"))

      parser.add_option("--repo", type='int', metavar="REPO#", help=_("query at event for a repo"))

      (options, args) = parser.parse_args(args)

      if len(args) < 1:
@@ -5382,7 +5382,7 @@ 

      parser.add_option("--used", action='store_true', help=_("List which tags use the repo(s)"))

      parser.add_option("--inherit", action='store_true', help=_("Follow tag inheritance when selecting by tag"))

      parser.add_option("--event", type='int', metavar="EVENT#", help=_("Query at event"))

-     parser.add_option("--ts", type='int', metavar="TIMESTAMP", help=_("Query at timestamp"))

+     parser.add_option("--ts", type='int', metavar="TIMESTAMP", help=_("Query at last event before timestamp"))

      parser.add_option("--repo", type='int', metavar="REPO#",

                              help=_("Query at event corresponding to (nonexternal) repo"))

      parser.add_option("--quiet", action="store_true", default=goptions.quiet,

@@ -629,7 +629,7 @@ 

    --latest-only     Tag only the latest build of each package

    --inherit-builds  Include all builds inherited into the source tag into the

                      dest tag

-   --ts=TS           Clone tag at a specific timestamp

+   --ts=TIMESTAMP    Clone tag at last event before specific timestamp

    --event=EVENT     Clone tag at a specific event

    --repo=REPO       Clone tag at a specific repo event

    -v, --verbose     show changes

@@ -190,7 +190,7 @@ 

  Options:

    -h, --help      show this help message and exit

    --event=EVENT#  query at event

-   --ts=TIMESTAMP  query at timestamp

+   --ts=TIMESTAMP  query at last event before timestamp

    --repo=REPO#    query at event for a repo

    --show-blocked  Show blocked packages

  """ % self.progname)

@@ -248,6 +248,6 @@ 

    --type=TYPE     Show builds of the given type only.  Currently supported

                    types: maven, win, image

    --event=EVENT#  query at event

-   --ts=TIMESTAMP  query at timestamp

+   --ts=TIMESTAMP  query at last event before timestamp

    --repo=REPO#    query at event for a repo

  """ % self.progname)

Maybe should be "query events prior to timestamp"?

Also should this be changed for other --ts options such as in:
anon_handle_list_tagged
anon_handle_list_groups
anon_handle_list_tag_inheritance
anon_handle_taginfo
anon_handle_list_external_repos

rebased onto 2a083afebd4ab2a7eb39a817873df095d957a182

2 years ago

rebased onto ff407115bdffcd6163e8cd4864c607d2167875ef

2 years ago

rebased onto 631f186b73e1e5c5e3a2cddb4c712b3f05872850

2 years ago

rebased onto 87bb4518735a4c53b46b27854ceed326f6c83d30

2 years ago

rebased onto 4fea94c

2 years ago

Metadata Update from @tkopecek:
- Pull-request tagged with: no_qe

2 years ago

Commit 1ef565f fixes this pull-request

Pull-Request has been merged by tkopecek

2 years ago