PR#1767: check ConfigParser object rather than config path list - koji

koji

#1767 check ConfigParser object rather than config path list

Merged 4 years ago by mikem. Opened 4 years ago by julian8628.

julian8628/koji issue/1763 into master

check ConfigParser object rather than config path list

Yu Ming Zhu • 4 years ago

6a414b1

koji/__init__.py

file modified

+1 -1

		`@@ -1776,7 +1776,7 @@`
		`result[name] = value`

		`# Check if the specified profile had a config specified`
		`- if configs and not got_conf:`
		`+ if config.sections() and not got_conf:`
		`raise ConfigurationError("no configuration for profile name: %s" % profile_name)`

		`# special handling for cert defaults`

julian8628 commented 4 years ago

fixes: #1763

mikem commented 4 years ago

:thumbsup:

mikem commented 4 years ago

Looking at this code now, it seems like we're probably doing the wrong thing with this check when config is missing entirely, but I'll file a separate follow up issue for that.

Edited 4 years ago by mikem

mikem commented 4 years ago

Commit c146423 fixes this pull-request