#1720 backward-compatible db conversion
Merged 4 years ago by tkopecek. Opened 4 years ago by tkopecek.
tkopecek/koji issue1718  into  master

@@ -83,11 +83,11 @@ 

  

  

  -- add all basic permissions

- INSERT INTO permissions (name) VALUES ('dist-repo') ON CONFLICT DO NOTHING;

- INSERT INTO permissions (name) VALUES ('host') ON CONFLICT DO NOTHING;

- INSERT INTO permissions (name) VALUES ('image-import') ON CONFLICT DO NOTHING;

- INSERT INTO permissions (name) VALUES ('sign') ON CONFLICT DO NOTHING;

- INSERT INTO permissions (name) VALUES ('tag') ON CONFLICT DO NOTHING;

- INSERT INTO permissions (name) VALUES ('target') ON CONFLICT DO NOTHING;

+ INSERT INTO permissions (name) SELECT 'dist-repo' WHERE NOT EXISTS (SELECT 1 FROM permissions WHERE name = 'dist-repo');

+ INSERT INTO permissions (name) SELECT 'host' WHERE NOT EXISTS (SELECT 1 FROM permissions WHERE name = 'host');

+ INSERT INTO permissions (name) SELECT 'image-import' WHERE NOT EXISTS (SELECT 1 FROM permissions WHERE name = 'image-import');

+ INSERT INTO permissions (name) SELECT 'sign' WHERE NOT EXISTS (SELECT 1 FROM permissions WHERE name = 'sign');

+ INSERT INTO permissions (name) SELECT 'tag' WHERE NOT EXISTS (SELECT 1 FROM permissions WHERE name = 'tag');

+ INSERT INTO permissions (name) SELECT 'target' WHERE NOT EXISTS (SELECT 1 FROM permissions WHERE name = 'target');

  

  COMMIT;

PG <= 9.4 doesn't support INSERT INTO ... ON CONFLICT ... syntax

Fixes: https://pagure.io/koji/issue/1718

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

4 years ago

Why not to just bump pgsql version?

koji still supports RHEL/CentOS 6 (so theoretically pg 8.4).

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

4 years ago

Commit beff0de fixes this pull-request

Pull-Request has been merged by tkopecek

4 years ago